OptIn assets and triggers #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1184 +/- ##
==========================================
- Coverage 87.73% 87.64% -0.10%
==========================================
Files 256 260 +4
Lines 10922 10988 +66
==========================================
+ Hits 9582 9630 +48
- Misses 920 935 +15
- Partials 420 423 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rowanseymour
force-pushed
the
optins
branch
from
ab7ab25 to
33437cd
Compare
rowanseymour
commented
Sep 14, 2023
assets/optin.go
Outdated
| // "name": "Joke Of The Day", | ||
| // "channel": { | ||
| // "uuid": "204e5af9-42c3-4d46-8aab-ce204dff25b4", | ||
| // "name": "Facebook" |
There was a problem hiding this comment.
making optins channel specific.. because we're going to associate auth keys with optins and they are obviously channel specific
rowanseymour
force-pushed
the
optins
branch
from
33437cd to
233276a
Compare
rowanseymour
commented
Sep 14, 2023
| @@ -19,7 +19,7 @@ type Channel struct { | |||
| } | |||
|
|
|||
| // NewChannel creates a new channel | |||
| func NewChannel(uuid assets.ChannelUUID, name string, address string, schemes []string, roles []assets.ChannelRole, parent *assets.ChannelReference) assets.Channel { | |||
rowanseymour
force-pushed
the
optins
branch
from
5b39aa4 to
a0eee0b
Compare
rowanseymour
force-pushed
the
optins
branch
from
a0eee0b to
eeff921
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that in a flow triggered by an optin or optout, you can do
@trigger.optin,@trigger.optin.nameetcAnd whatever action we add to solicit an optin needs to know about optins.